Merged
Conversation
ec67f1b to
9c4360c
Compare
Member
Author
|
Ignore the failures in 2.5, it's done this before and seems an issue with rubygems/bundler/ruby-setup AFAICT. |
636567b to
271699d
Compare
jeremyevans
requested changes
Jan 19, 2023
Contributor
jeremyevans
left a comment
There was a problem hiding this comment.
This will be OK once the the Ruby 2.4/2.5 CI removal is no longer included. I fixed the CI tests for Ruby 2.5 in #2021.
Contributor
|
@ioquatix Can you remove the first commit and then rebase on master? Then this should be good to merge. |
271699d to
3a7a8ba
Compare
Member
Author
|
Okay done. |
3a7a8ba to
46f67a2
Compare
46f67a2 to
c993a37
Compare
jeremyevans
approved these changes
Jan 20, 2023
8 tasks
delfinag
added a commit
to envato/jwt_signed_request
that referenced
this pull request
Jun 21, 2024
This version of `rack` makes the request body optional. Omitting to explicitly set `rack.input` on GET's will cause the request's header verification to fail with: ``` NoMethodError: undefined method `read' for nil:NilClass ``` because there is no `request.body` to read the JWT token from. See rack/rack#2018.
h-lame
added a commit
to meetcleo/apipie-rails
that referenced
this pull request
Jul 5, 2024
Ever since rack/rack#2018 `rack.input` has been optional so we can't assume it's there and call `read` or `rewind` on it in `Apipie::Extractor::Recorder`. Using safe navigation to call these methods seems like the simplest approach because we want to look for `rack.request.form_hash` instead in both the situation where `rack.input` is missing, or it's empty.
h-lame
added a commit
to meetcleo/apipie-rails
that referenced
this pull request
Jul 5, 2024
Ever since rack/rack#2018 `rack.input` has been optional so we can't assume it's there and call `read` or `rewind` on it in `Apipie::Extractor::Recorder`. Using safe navigation to call these methods seems like the simplest approach because we want to look for `rack.request.form_hash` instead in both the situation where `rack.input` is missing, or it's empty.
mathieujobin
pushed a commit
to Apipie/apipie-rails
that referenced
this pull request
Jul 9, 2024
#939) * Update how we use Rack::Utils to get status codes As part of rack/rack#2137 (released in Rack 3) Rack changed the values of `Rack::Utils::SYMBOL_TO_STATUS_CODE` so asking for `:unprocessable_entity` now returns `nil`. The guidance has always been to use `Rack::Util.status_code` (present in the API since Rack 1.1) so let's just do that. * Handle a missing `rack.input` in the env Ever since rack/rack#2018 `rack.input` has been optional so we can't assume it's there and call `read` or `rewind` on it in `Apipie::Extractor::Recorder`. Using safe navigation to call these methods seems like the simplest approach because we want to look for `rack.request.form_hash` instead in both the situation where `rack.input` is missing, or it's empty. * Add rubocop-rspec_rails and get rubocop run to green In rubocop/rubocop-rspec#1848 rubocop-rspec extracted some cops to separate gems, and because we referenced one of them in our rubocop_todo.yml the whole rubocop process wouldn't run because it doesn't like config for cops it doesn't know about. We introducing the missing gem, `rubocop-rspec_rails`, and fix the name in the config to let us run rubocop again. There is one infraction that exists in the source so we fix that to get us to a green rubocop run. * Only add rubocop-rspec_rails for ruby >-= 2.7 It's only available for 2.7+ and we still run this build on 2.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also introduce
Rack::Multipart::MissingInputErrorfor improved handling of missing input in#parse_multipart.Fixes #1994. Fixes #1995.