ViewStatusMessagesServlet requires method POST for button 'Clear'#971
Merged
ceki merged 1 commit intoqos-ch:masterfrom Sep 29, 2025
Merged
ViewStatusMessagesServlet requires method POST for button 'Clear'#971ceki merged 1 commit intoqos-ch:masterfrom
ceki merged 1 commit intoqos-ch:masterfrom
Conversation
b949f64 to
5d2833d
Compare
The button 'Clear' has a side-effect and should not work with GET, as GET is considered a Safe Method not taking an action other than retrieval. https://www.rfc-editor.org/rfc/rfc2616#section-9.1.1 I'd like to restrict users from doing any changes by restricting them to method GET. With that said one might consider this change as a security fix. Signed-off-by: Ralf Wiebicke <ralf.wiebicke@exedio.com>
5d2833d to
d8430d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The button 'Clear' has a side-effect and should not work with GET, as GET is considered a Safe Method not taking an action other than retrieval.
https://www.rfc-editor.org/rfc/rfc2616#section-9.1.1
I'd like to restrict users from doing any changes by restricting them to method GET. With that said one might consider this change as a security fix.