Fix sys.platform when cross-compiling with emscripten#14888
Merged
JelleZijlstra merged 2 commits intomasterfrom Apr 24, 2023
Merged
Fix sys.platform when cross-compiling with emscripten#14888JelleZijlstra merged 2 commits intomasterfrom
JelleZijlstra merged 2 commits intomasterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Closed
wesleywright
pushed a commit
that referenced
this pull request
Apr 24, 2023
This is a workaround for correctly detecting the platform when building mypy with mypyc on the Emscripten platform. This fixes mypyc/mypy_mypyc-wheels#62. `pyodide build` overrides `sysconfig` for the host based on the target (confirmed on the pyodide matrix, [see also where the code is actually changed](https://github.com/pyodide/pyodide/blob/e835bf05ff4aa463024aaeb9689ae70ea5771314/pyodide-build/pyodide_build/pypabuild.py#L43-L50)). This should only change things when checking/building for the emscripten platform. There isn't really a cleaner workaround that I can think of unfortunately, the main issue is cross compiling is tricky with setuptools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for correctly detecting the platform when building mypy with mypyc on the Emscripten platform. This fixes mypyc/mypy_mypyc-wheels#62.
pyodide buildoverridessysconfigfor the host based on the target (confirmed on the pyodide matrix, see also where the code is actually changed).This should only change things when checking/building for the emscripten platform. There isn't really a cleaner workaround that I can think of unfortunately, the main issue is cross compiling is tricky with setuptools.