fix: Use missing-argument sentinel for dump_version argument#1286
Merged
RonnyPfannschmidt merged 2 commits intopypa:mainfrom Mar 27, 2026
Merged
fix: Use missing-argument sentinel for dump_version argument#1286RonnyPfannschmidt merged 2 commits intopypa:mainfrom
RonnyPfannschmidt merged 2 commits intopypa:mainfrom
Conversation
5c3f4d5 to
7494a71
Compare
Contributor
|
the warning intentionally happens at missing parameter - the parameter is required |
Contributor
Author
|
The warning says to pass |
Contributor
|
You are right thanks for calling out |
Contributor
|
I can merge/ release after a changelog fragment is added |
7494a71 to
5f018e9
Compare
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Mar 29, 2026
## 10.0.5 (2026-03-27) ### Fixed - Allow `dump_version()` deprecation warning to be silenced by passing `scm_version=None`. ([#1286](pypa/setuptools-scm#1286)) - Remove `[tool.uv.sources]` from `setuptools-scm/pyproject.toml` to fix sdist builds outside the workspace — the workspace root already declares the source mapping for development. ([#1330](pypa/setuptools-scm#1330)) ## 10.0.4 (2026-03-27) ### Fixed - Anchor ``get_version`` in ``setup.py`` with ``relative_to`` and ``fallback_root`` so SCM fallbacks (e.g. ``PKG-INFO``) do not resolve against the wrong directory when the build cwd is the workspace or repo root. ([#1302](pypa/setuptools-scm#1302)) - Enter ``GlobalOverrides`` for ``SETUPTOOLS_SCM`` when using ``setuptools_scm.get_version`` / ``_get_version``, avoiding implicit context warnings for direct API callers. ([#1314](pypa/setuptools-scm#1314)) ### Miscellaneous - Upgrade pre-commit hooks (Ruff, mypy, codespell), align locked Ruff with hooks, and add Ruff per-file configuration for setuptools_scm re-export modules. ([#1311](pypa/setuptools-scm#1311)) ## 10.0.3 (2026-03-26) ### Fixed - Remove monorepo-only ``../vcs-versioning/src`` from ``build-system.backend-path`` so sdists install under PEP 517 (paths must stay inside the source tree). ([#1306](pypa/setuptools-scm#1306)) ### Miscellaneous - Add `griffecli` to test dependencies so the API stability check keeps working after the Griffe CLI was split into a separate package. ([#1310](pypa/setuptools-scm#1310)) ## 10.0.2 (2026-03-25) ### Fixed - Fix version file not generated for editable installs. Version files are now written to the source tree by default during inference (restoring pre-10.x behavior), and also registered as ``build_py`` outputs so strict editable installs include them in the persistent auxiliary directory. Set ``SETUPTOOLS_SCM_WRITE_TO_SOURCE=0`` to disable source-tree writing (e.g., for read-only source directories). ([#1298](pypa/setuptools-scm#1298)) ## 10.0.1 (2026-03-09) ### Miscellaneous - Simplify release tag creation to use a single ``createRelease`` API call instead of separate ``createTag``/``createRef``/``createRelease`` calls, avoiding dangling tag objects on partial failures. ([#release-pipeline](https://github.com/pypa/setuptools-scm/issues/release-pipeline)) ## 10.0.0 (2026-02-26) ### Removed - Drop Python 3.8 and 3.9 support. Minimum Python version is now 3.10. ([#1228](pypa/setuptools-scm#1228)) ### Added - setuptools-scm now depends on vcs-versioning for core version inference logic. This enables other build backends to use the same version inference without setuptools dependency. ([#1228](pypa/setuptools-scm#1228)) - Version files (``write_to`` and ``version_file``) are now written to the build directory during ``build_py`` instead of the source tree during version inference. This enables installing packages from read-only source directories (e.g., Bazel builds). Path transformation is automatically applied for ``src/`` layouts - a configured path like ``src/mypackage/_version.py`` is correctly written to ``mypackage/_version.py`` in the build directory based on the ``package_dir`` configuration. To restore the old behavior of writing version files at inference time (useful for development workflows), set the environment variable ``SETUPTOOLS_SCM_WRITE_TO_SOURCE=1``. ([#1252](pypa/setuptools-scm#1252)) ### Fixed - Fix issue #1231: Don't warn about tool.setuptools.dynamic.version conflict when only using file finder without version inference. ([#1231](pypa/setuptools-scm#1231)) ### Miscellaneous - Refactored should_infer from method to standalone function for better code organization. ([#1228](pypa/setuptools-scm#1228)) - Updated mypy version template test to use uvx, ensuring generated version files remain compatible with Python 3.8+ consumers. ([#1228](pypa/setuptools-scm#1228)) - Refactored TestBuildPackageWithExtra into parametrized function with custom INI-based decorator for cleaner test data specification. ([#1228](pypa/setuptools-scm#1228)) - Internal refactoring: modernized type annotations, improved CLI type safety, and enhanced release automation infrastructure. ([#1228](pypa/setuptools-scm#1228))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1183 added a warning that it claimed could be silenced by passing
scm_version=None, but it usesNoneas its missing value sentinel, meaning the warning can never be silenced. This uses a sentinel object as a default value, so that passingNonedoes successfully silence the warning and opt in to default behavior.