Conversation
31468cd to
9fcd7fa
Compare
pkg_resources as py.typed
…sources-explicit-public-return-annotations
|
@abravalheri @jaraco out of all my currently open PRs, this is the one I'd like to prioritise most, as it marks I've also been thinking of maybe not enforcing |
jaraco
left a comment
There was a problem hiding this comment.
LGTM. I didn't see any changes in the implementation. Please confirm that's the case.
The only risk with merging this is if we have to back out #4457, probably some of the type checking will need to back off, but that outcome seems unlikely at this point.
…sources-explicit-public-return-annotations
I re-reviewed the PR and I don't see any change in implementation either.
Even that I feel would be minor. |
Summary of changes
Merge #4390 and #4391 first !Addresses #4397 (comment)
This also marks
pkg_resourcesaspy.typedas it is now more on par (or even improved) over typeshed's stubs.With the exception of#4457externimports causing a loss of typing, but that's a completely different discussion andpkg_resourcesas a deprecated module, isn't affected too badly.Step 4 & 5 of #2345 (comment)
Pull Request Checklist
newsfragments/.(See documentation for details)