Conversation
|
The manylinux tags latest thing is broken on other PRs too. |
ab559ae to
ac63866
Compare
|
reported that issue over on manylinux- pypa/manylinux#1581 |
|
Is it only manylinux1? We could just skip if this happens. |
3d3c5b7 to
f82e4a4
Compare
joerick
left a comment
There was a problem hiding this comment.
can we also specify in noxfile.py that nox should prefer uv, if it's available?
| env = os.environ.copy() | ||
| # CUSTOM_COMPILE_COMMAND is a pip-compile option that tells users how to | ||
| # regenerate the constraints files | ||
| env["CUSTOM_COMPILE_COMMAND"] = f"nox -s {session.name}" |
There was a problem hiding this comment.
Not critical, but it looks like this isn't having an effect on uv yet, found an issue here- astral-sh/uv#1527
There was a problem hiding this comment.
It's added now. Though IMO it's not really required, as unlike before, you don't need any special setup to compile it.
There was a problem hiding this comment.
It's called UV_CUSTOM_PIP_COMPILE, even though PR and release notes get it wrong. astral-sh/uv#2554
|
We can, but it would require the latest version of nox. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2a040f4 to
bb1f0d2
Compare
This cuts the time down from 40 seconds to 4 seconds, and doesn't require pre-installing every version of Python. It also is easy to run without nox too, since it's now just a simple command that doesn't require a Python version present.
It also adds a lock on importlib-metadata on older Pythons; build does require importlib-metadata on older Pythons, so guessing pip-tools just missed this?
This fixes running the noxfile with uv, too, and silences an incorrect warning from pylint.