Merged
Conversation
layday
reviewed
Apr 10, 2026
|
|
||
| import pyproject_hooks | ||
|
|
||
| from typing_extensions import Self |
Member
There was a problem hiding this comment.
We don't depend on typing_extensions at runtime.
Contributor
Author
There was a problem hiding this comment.
Yes, I accidentally added this from testing the currently commented codes.
94c72be to
53f2312
Compare
gaborbernat
approved these changes
Apr 10, 2026
53f2312 to
e7a8094
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
e7a8094 to
0b73979
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding more ruff codes. The commented ones are ones I'd like to add eventually, but will need some changes.
Based on the output of
uvx --from sp-repo-review[cli] sp-ruff-checks ..