Merged
Conversation
… <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
01bd621 to
c28cb4d
Compare
c28cb4d to
a8ae94f
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
a8ae94f to
0a4604c
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Member
|
I don't think return types are necessary in the test suite except for where the type checker is unable to infer them. Some of the parameters are underspecified, e.g. |
Contributor
Author
|
The return types for tests have to be None, and this is actually something that changed in PyTest 7 or so. Having None ensures that you don’t accidentally try to return something from a test function. I tried to clean up some of the Any, can try to see if I can get more. Yes on the FixtureRequest. I wish that fixture request was generic. |
gaborbernat
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Used copilot CLI and gpt-5-mini to add types to the test suite.
Changelog
docs/changelog/<pr_number>.<type>.rstfeature,bugfix,doc,removal,misc123.feature.rstcontainingAdd custom backend support - by :user:`yourname`Checklist
tox)tox -e fix)tox -e type)tox -e docs)