Runtime deprecation of tagMap & typeMap aliases#72
Merged
droideck merged 1 commit intopyasn1:mainfrom Aug 22, 2024
Merged
Conversation
59dfe0a to
cae026d
Compare
tagMap & typeMap aliases
cae026d to
2f95e2a
Compare
Avasam
commented
Aug 22, 2024
droideck
approved these changes
Aug 22, 2024
droideck
left a comment
There was a problem hiding this comment.
Besides the minor nitpick, looks good! Thank you!
| return cls._instance | ||
|
|
||
| def __getattr__(self, attr): | ||
| def __getattr__(self, attr: str): |
There was a problem hiding this comment.
It's a minor nitpick, but I'd rather keep the commit changes exactly about the subject, nothing additional.
We can have more PRs in the future for type changes and this change together with other stuff. :)
3859bbc to
803ec95
Compare
803ec95 to
d9703b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
CC @tiran