Fix duplicated and missing declarations#64
Conversation
|
|
||
| class Sequence(univ.Sequence): | ||
| componentType = namedtype.NamedTypes( | ||
| namedtype.OptionalNamedType('name', univ.OctetString()) |
There was a problem hiding this comment.
The current definition passes an empty string to OctetString:
namedtype.OptionalNamedType('name', univ.OctetString(''))
33a3384 to
0f78ee9
Compare
1aa9ce0 to
445dd82
Compare
|
|
||
| from tests.base import BaseTestCase | ||
|
|
||
| from pyasn1.error import PyAsn1Error |
There was a problem hiding this comment.
This missing import implies that the except PyAsn1Error path in these tests was never being taken (or the tests not run). That's something you might wanna look into. Maybe the try-except should be removed instead ?
There was a problem hiding this comment.
We haven't had any failures in the tests. That is good:)
I think leaving the excepts in the tests is okay. If the test fails, it'll help explain what was expected.
But yes, we need the import fix you did.
|
|
||
| from tests.base import BaseTestCase | ||
|
|
||
| from pyasn1.error import PyAsn1Error |
There was a problem hiding this comment.
We haven't had any failures in the tests. That is good:)
I think leaving the excepts in the tests is okay. If the test fails, it'll help explain what was expected.
But yes, we need the import fix you did.
Various duplicated declarations and a missing import I found