Skip to content

Remove python2 code from compat.octets#60

Merged
droideck merged 1 commit intopyasn1:mainfrom
Avasam:compat.octets-python2-code
Jul 30, 2024
Merged

Remove python2 code from compat.octets#60
droideck merged 1 commit intopyasn1:mainfrom
Avasam:compat.octets-python2-code

Conversation

@Avasam
Copy link
Copy Markdown

@Avasam Avasam commented Apr 1, 2024

81ce8d0 removed support for Python 2, but there's still tons of leftover python2 dead code.

Here's a cleanup scoped specifically to the compat.octets module.

@Avasam Avasam force-pushed the compat.octets-python2-code branch from fe28ca4 to 326e765 Compare April 1, 2024 01:12
Copy link
Copy Markdown

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@droideck droideck merged commit 6f770ba into pyasn1:main Jul 30, 2024
@Avasam Avasam deleted the compat.octets-python2-code branch July 30, 2024 17:39
@Avasam
Copy link
Copy Markdown
Author

Avasam commented Jul 31, 2024

Thanks for the merge! I resolved the conflicts on my other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants