Implement dsize and dcompact functions for Puma::HttpParser#3828
Merged
nateberkopec merged 1 commit intopuma:mainfrom Nov 20, 2025
Merged
Implement dsize and dcompact functions for Puma::HttpParser#3828nateberkopec merged 1 commit intopuma:mainfrom
nateberkopec merged 1 commit intopuma:mainfrom
Conversation
`dsize` allows these objects to be properly reported in heap dumps. `dcompact` allows the GC to move the other objects this one refers to. I also wanted to implement write barrier, but this is made difficult by the current parser architecture. But I have ideas on how to change it that may or may not pan out.
Member
|
|
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dsizeallows these objects to be properly reported in heap dumps.dcompactallows the GC to move the other objects this one refers to.I also wanted to implement write barrier, but this is made difficult by the current parser architecture. But I have ideas on how to change it that may or may not pan out.