Skip to content

Update JSpecify annotation fully-qualified names#3608

Merged
Rawi01 merged 6 commits intoprojectlombok:masterfrom
jyoo980:master
Mar 1, 2024
Merged

Update JSpecify annotation fully-qualified names#3608
Rawi01 merged 6 commits intoprojectlombok:masterfrom
jyoo980:master

Conversation

@jyoo980
Copy link
Copy Markdown
Contributor

@jyoo980 jyoo980 commented Feb 17, 2024

Updates the HandlerUtil with the org.jspecify.annotations.NonNull annotation here

@msridhar
Copy link
Copy Markdown
Contributor

@jyoo980 what a coincidence, I just opened #3613 which does something similar but updates the copyable annotations. Do you want to just merge my commit into this PR and then I can close the other one?

@jyoo980
Copy link
Copy Markdown
Contributor Author

jyoo980 commented Feb 22, 2024

@msridhar sure, sounds good. I'll try to get your patch merged into mine today.

Comment thread AUTHORS Outdated
@jyoo980
Copy link
Copy Markdown
Contributor Author

jyoo980 commented Feb 22, 2024

Closes #3613

@msridhar
Copy link
Copy Markdown
Contributor

Thanks for merging in the other change so quick @jyoo980! We may also want to re-title this PR to capture the new scope

@jyoo980 jyoo980 changed the title Add jspecify @NonNull annotation Update JSpecify annotation fully-qualified names Feb 22, 2024
@jyoo980 jyoo980 requested a review from msridhar February 22, 2024 22:37
Copy link
Copy Markdown
Contributor

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoo980
Copy link
Copy Markdown
Contributor Author

jyoo980 commented Feb 28, 2024

@Rawi01 is there anything else I can do to help get this PR merged?

@rspilker
Copy link
Copy Markdown
Collaborator

This is part of the latest edge release, all feedback is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants