Make link distinguishable from surrounding text with underline styling#3866
Merged
llastflowers merged 2 commits intomainfrom Jan 22, 2026
Merged
Make link distinguishable from surrounding text with underline styling#3866llastflowers merged 2 commits intomainfrom
llastflowers merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 2296da4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an accessibility remediation issue by making links visually distinguishable from surrounding text through underline styling, ensuring compliance with accessibility standards that require links to be identifiable by more than color alone.
Changes:
- Added inline underline styling to a link in the OcticonSymbols preview playground
- Added changeset documentation for the patch release
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| previews/primer/alpha/octicon_symbols_preview/playground.html.erb | Applied text-decoration: underline to MDN docs link |
| .changeset/proud-rocks-hide.md | Added changeset entry documenting the accessibility fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3ecd649 to
7b6ec12
Compare
Add underline styling to link for better visibility.
francinelucca
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Screenshots
Before and after:
Integration
N/A
List the issues that this change affects.
Relates to https://github.com/github/accessibility-audits/issues/14761
Risk Assessment
What approach did you choose and why?
Underline styling is the most common/simple way to address this issue, so I went that route.
Anything you want to highlight for special attention from reviewers?
N/A
Accessibility
Fix for a11y audit remediation issue
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.