Make AvatarStack accessible via keyboard navigation#3849
Merged
llastflowers merged 5 commits intomainfrom Jan 13, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: f7ccecc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Enhance accessibility for AvatarStack by enabling keyboard navigation.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds keyboard accessibility to the AvatarStack component by making expandable avatar stacks focusable via the tab key. This addresses a SEV1 accessibility bug where expandable avatar stacks were not keyboard-accessible.
Changes:
- Added logic to conditionally set
tabindex="0"on expandable avatar stacks to enable keyboard navigation - Skips adding tabindex when the stack is already focusable (tooltipped or contains linked avatars) to avoid redundant tab stops
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
francinelucca
approved these changes
Jan 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Make AvatarStack accessible via keyboard navigation
Integration
N/A
List the issues that this change affects.
Relates to https://github.com/github/accessibility-audits/issues/14776
Risk Assessment
What approach did you choose and why?
When an AvatarStack is expandable, make it keyboard-accessible. Skip if the stack is tooltipped (which already makes it focusable) or when any of the avatars are links (also already focusable) to avoid redundant/extra tab stops.
Confirmed that this behavior is already in place in the primer/react AvatarStack and used a similar approach at the component level.
Anything you want to highlight for special attention from reviewers?
N/A
Accessibility
This addresses a SEV1 a11y bug where the AvatarStacks in this story were not keyboard-accessible.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.