Fix: Always use aria-selected for ActionList items with role="option" (#3893)

liuliu-dev · web-flow · commit 024dc7e3647e · 2026-01-29T18:14:58.000Z
diff --git a/.changeset/slick-walls-retire.md b/.changeset/slick-walls-retire.md
@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Always use `aria-selected` for ActionList items with role="option".
diff --git a/app/components/primer/alpha/action_list/item.rb b/app/components/primer/alpha/action_list/item.rb
@@ -302,7 +302,8 @@ def before_render
           if @list.allows_selection?
             @content_arguments[:aria] = merge_aria(
               @content_arguments,
-              { aria: @list.aria_selection_variant == :selected ? { selected: active? } : { checked: active? } }
+              # Always use aria-selected for listbox (role="option" requires aria-selected per WAI-ARIA 1.2)
+              { aria: @list.acts_as_listbox? || @list.aria_selection_variant == :selected ? { selected: active? } : { checked: active? } }
             )
           end
 

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@primer/view-components': patch
 +---
++
 +Always use `aria-selected` for ActionList items with role="option".
Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,8 @@ def before_render`
`302`	`302`	`if @list.allows_selection?`
`303`	`303`	`@content_arguments[:aria] = merge_aria(`
`304`	`304`	`@content_arguments,`
`305`		`- { aria: @list.aria_selection_variant == :selected ? { selected: active? } : { checked: active? } }`
	`305`	`+ # Always use aria-selected for listbox (role="option" requires aria-selected per WAI-ARIA 1.2)`
	`306`	`+ { aria: @list.acts_as_listbox? \|\| @list.aria_selection_variant == :selected ? { selected: active? } : { checked: active? } }`
`306`	`307`	`)`
`307`	`308`	`end`
`308`	`309`