Skip to content

Added support for hash field expiration commands - #1456

Merged
tillkruss merged 19 commits into
predis:v2.xfrom
vladvildanov:vv-hash-field-expiration
Oct 15, 2024
Merged

tillkruss merged 19 commits into
predis:v2.xfrom
vladvildanov:vv-hash-field-expiration

Conversation

@vladvildanov

@vladvildanov vladvildanov commented Apr 29, 2024 •

Copy link
Copy Markdown
Contributor

This PR adds new commands operates on hash field expiration functionality

@vladvildanov
vladvildanov requested a review from tillkruss as a code owner April 29, 2024 12:37
@vladvildanov
vladvildanov requested a review from a team April 29, 2024 12:37
@vladvildanov
vladvildanov marked this pull request as draft April 29, 2024 12:37
@vladvildanov

vladvildanov commented Apr 29, 2024 •

Copy link
Copy Markdown
Contributor Author

PR still on draft, until:

  • Redis unstable docker image will support given functionality

@coveralls

coveralls commented Apr 29, 2024 •

Copy link
Copy Markdown

Coverage Status

coverage: 80.522% (+0.09%) from 80.429%
when pulling 756efc7 on vladvildanov:vv-hash-field-expiration
into 0a92618 on predis:v2.x.

@vladvildanov
vladvildanov force-pushed the vv-hash-field-expiration branch from cbc69b4 to b59f5fb Compare May 17, 2024 09:21
Comment thread src/ClientContextInterface.php Outdated
Comment thread src/Command/Argument/Hash/CommonExpiration.php Outdated
Comment thread src/Command/Argument/Hash/CommonExpiration.php Outdated
Comment thread src/Command/Argument/Hash/HGetFArguments.php Outdated
Comment thread src/Command/Redis/HEXPIRETIME.php
Comment thread src/Connection/Replication/MasterSlaveReplication.php
Comment thread src/Connection/Replication/MasterSlaveReplication.php
Comment thread src/Command/Argument/Hash/CommonExpiration.php Outdated

@gerzse gerzse left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can't use the "Approve" button, but consider this approved from my side.

@vladvildanov
vladvildanov force-pushed the vv-hash-field-expiration branch from 82eab7a to c522417 Compare June 5, 2024 14:05
@vladvildanov
vladvildanov marked this pull request as ready for review June 11, 2024 09:36
@vladvildanov
vladvildanov requested a review from gerzse July 5, 2024 13:37
@vladvildanov
vladvildanov requested a review from a team July 31, 2024 08:30
@jdecool

jdecool commented Sep 12, 2024

Copy link
Copy Markdown

Very interesting.

Can it be merged soon ?

@rusowyler

Copy link
Copy Markdown

Hey guys! Can we merge this PR soon?

@tillkruss
tillkruss merged commit 8fbd34c into predis:v2.x Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants