compat internal types: import and re-export PreactElement#3228
Merged
rschristian merged 2 commits intopreactjs:mainfrom Apr 23, 2024
Merged
compat internal types: import and re-export PreactElement#3228rschristian merged 2 commits intopreactjs:mainfrom
rschristian merged 2 commits intopreactjs:mainfrom
Conversation
rschristian
approved these changes
Apr 23, 2024
Member
rschristian
left a comment
There was a problem hiding this comment.
Sorry this was missed and sat for so long
Merged
This was referenced Aug 14, 2024
This was referenced Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
PreactElementis used in this module we should alsoimportit instead of only doing theexport {} from.https://github.com/henryqdineen/preact/blob/a1309b8e1a51ee51ca93848d69dc30a5d3ad0356/compat/src/internal.d.ts#L25
I understand that these are just internal types that are used for
ts-checkbut it was just something that I noticed. It seems like it has been innocuous so far. Thanks!