Skip to content

[java] Fix #4861 - UnusedPrivateMethod FP in JDK classes#5376

Merged
adangel merged 1 commit intopmd:mainfrom
oowekyala:issue4861-unusedprivatemethod-fp-jdk
Dec 14, 2024
Merged

[java] Fix #4861 - UnusedPrivateMethod FP in JDK classes#5376
adangel merged 1 commit intopmd:mainfrom
oowekyala:issue4861-unusedprivatemethod-fp-jdk

Conversation

@oowekyala
Copy link
Copy Markdown
Member

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@ghost
Copy link
Copy Markdown

ghost commented Nov 29, 2024

1 Message
📖 Compared to main:
This changeset changes 42 violations,
introduces 2 new violations, 0 new errors and 0 new configuration errors,
removes 7 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@adangel adangel added this to the 7.9.0 milestone Dec 14, 2024
Copy link
Copy Markdown
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

* the AST symbol. Since it only applies to these types we
* check that the package name is java.lang, to avoid doing
* that for other types.
*/
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updating this comment a bit, to mention, that
this is only relevant, when PMD is used to analyze OpenJDK sources.

@adangel adangel merged commit bbbc9a2 into pmd:main Dec 14, 2024
adangel added a commit that referenced this pull request Dec 14, 2024
adangel added a commit that referenced this pull request Dec 14, 2024
Merge pull request #5376 from oowekyala:issue4861-unusedprivatemethod-fp-jdk
@oowekyala oowekyala deleted the issue4861-unusedprivatemethod-fp-jdk branch December 14, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java] UnusedPrivateMethod - false positive with static methods in core JDK classes

2 participants