[cpp] Ignore literals and ignore identifiers capability to C++ CPD#5040
Merged
[cpp] Ignore literals and ignore identifiers capability to C++ CPD#5040
Conversation
Generated by 🚫 Danger |
Member
|
@jdupak thanks! Happy to see you were able to manage this! Overall this looks very neat! This covers all pointers I gave you. The one thing missing for sure are tests. You can once again get inspiration from how Java test these. |
Member
|
Hi @jdupak , thanks for the PR! Is there a chance you can look into creating a unit test for this new feature? |
Contributor
Author
|
Hi,
I am so sorry, I got my JAR and forgot about this.
I will do my best to send it by Monday.
…On Sun, 13 Oct 2024, at 12:10, Andreas Dangel wrote:
Hi @jdupak <https://github.com/jdupak> , thanks for the PR! Is there a chance you can look into creating a unit test for this new feature?
—
Reply to this email directly, view it on GitHub <#5040 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFNB76BVT25JQNBMVQ3WFXLZ3JBJHAVCNFSM6AAAAABIHHZFJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYHEYTKMBYGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
adangel
added a commit
that referenced
this pull request
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Adds ignore literals and ignore identifiers capability to c++ cpd.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)