[java] Fix #2996 - CommentSize/CommentContent suppression#4939
Merged
[java] Fix #2996 - CommentSize/CommentContent suppression#4939
Conversation
Generated by 🚫 Danger |
oowekyala
commented
Apr 17, 2024
adangel
approved these changes
Dec 17, 2024
Member
adangel
left a comment
There was a problem hiding this comment.
Thanks!
I'll update the small fixes myself and merge it aftwards.
adangel
added a commit
that referenced
this pull request
Dec 17, 2024
adangel
added a commit
that referenced
this pull request
Dec 17, 2024
adangel
added a commit
that referenced
this pull request
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Suppressing violations of comment related rules doesn't work well right now, because they are reported against the compilation unit node. This adds some utilities to be able to report violations on a specific token. The RuleContext finds the closest node to the token and uses that to look for suppression annotations.
See also #2996 (comment)
Draft because probably other comment rules have the same problem.Java documentation rules have been updated, but there are two other PLSQL rules that still use the broken overload
addViolationWithPosition. I think we can land this without necessarily updating those.Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)