Conversation
adangel
reviewed
Dec 20, 2024
adangel
reviewed
Dec 20, 2024
Member
adangel
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Did you take the grammar from https://github.com/antlr/grammars-v4/tree/master/rust ? That's worth documenting somewhere, as languages evolve and grammars need to be kept up to date... so that we can update downstream/upstream if some parsing problem appears.
Contributor
Author
|
good point! I added a README to the directory where the grammar lives. I also deleted |
…x import order, add helloworld.txt to test data
jsotuyod
reviewed
Dec 21, 2024
Generated by 🚫 Danger |
adangel
added a commit
that referenced
this pull request
Dec 27, 2024
adangel
added a commit
that referenced
this pull request
Dec 27, 2024
Merge pull request #5414 from juliapaluch:add-rust-cpd
adangel
added a commit
to pmd/pmd.github.io
that referenced
this pull request
Dec 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR adds CPD support for Rust.
Ready?
./mvnw clean verifypasses (checked automatically by github actions)