Skip to content

[java] Improve LocalVariableCouldBeFinal #5003

Merged
adangel merged 3 commits intopmd:masterfrom
oowekyala:issue1619-localVariableCouldBeFinal-FP
May 31, 2024
Merged

[java] Improve LocalVariableCouldBeFinal #5003
adangel merged 3 commits intopmd:masterfrom
oowekyala:issue1619-localVariableCouldBeFinal-FP

Conversation

@oowekyala
Copy link
Copy Markdown
Member

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added this to the 7.2.0 milestone May 11, 2024
@ghost
Copy link
Copy Markdown

ghost commented May 11, 2024

1 Message
📖 Compared to master:
This changeset changes 1 violations,
introduces 2549 new violations, 0 new errors and 0 new configuration errors,
removes 282 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to master:
This changeset changes 1 violations,
introduces 4431 new violations, 0 new errors and 0 new configuration errors,
removes 221 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

Copy link
Copy Markdown
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel merged commit 7f0d148 into pmd:master May 31, 2024
adangel added a commit that referenced this pull request May 31, 2024
adangel added a commit that referenced this pull request May 31, 2024
Merge pull request #5003 from oowekyala:issue1619-localVariableCouldBeFinal-FP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java] LocalVariableCouldBeFinal should consider blank local variables [java] LocalVariableCouldBeFinal on 'size' variable in for loop

2 participants