Conversation
T4rk1n
reviewed
Apr 3, 2024
| logger.exception(msg) | ||
| return sys.modules.get(name, None) | ||
|
|
||
| else: |
alexcjohnson
approved these changes
Apr 9, 2024
Collaborator
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 very nice diagnosis & fix!
Contributor
|
Some tests are failing on CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3567
Also addresses plotly/dash#2797
Summary
Address the error described in #3567 by adjusting the module loading logic in
get_module.The error can be reproduced by following these steps.
As best I can tell, the error is caused by a race condition between the multiple threads in the Flask hot reloader, and the fact that Python adds a module to
sys.modulesbefore the module has been executed [1] [2]. If one thread attempts to loadorjsonafter it has been added tosys.modulesbut before it has been executed, we'll get the error.Fix
get_moduleso that whenshould_load=True, we just callimport_moduleright away instead of checkingsys.modulesfirst.import_modulecontains logic to verify that the module is fully initializedshould_load=Falseremains the same: If the module is insys.moduleswe return it, otherwise we returnNoneCode PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).