Skip to content

Deterministic sort order for plotly express modes#4429

Merged
alexcjohnson merged 2 commits intoplotly:masterfrom
alev000:sort-modes
Nov 17, 2023
Merged

Deterministic sort order for plotly express modes#4429
alexcjohnson merged 2 commits intoplotly:masterfrom
alev000:sort-modes

Conversation

@alev000
Copy link
Copy Markdown
Contributor

@alev000 alev000 commented Nov 17, 2023

Addresses #4428

Note: without the proposed code change to _core.py, the new tests fail intermittently; with the proposed change, they succeed consistently.

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

alexcjohnson
alexcjohnson approved these changes Nov 17, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Very nice test, thanks! Let's add a changelog entry then we can merge.

@alev000
Copy link
Copy Markdown
Contributor Author

alev000 commented Nov 17, 2023

I see a failure in python_38_orca here. From what I can see, this seems unrelated to the current PR. Is this potentially a flaky test failure, or a transient error that needs to be retried?

plotly/tests/test_orca/test_orca_server.py::test_ensure_orca_ping_and_proc

@alexcjohnson
Copy link
Copy Markdown
Collaborator

alexcjohnson commented Nov 17, 2023

Yep, just a flaky test - all good the second time around ☺️ - thanks again!

@alexcjohnson alexcjohnson merged commit d4a7c32 into plotly:master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alev000 @alexcjohnson