Handle extras option in IntegerValidator#4612
Merged
Conversation
LiamConnors
approved these changes
Jun 13, 2024
Contributor
Author
|
@LiamConnors please merge this PR once you added a changelog regarding the changes, etc. as required. |
Contributor
|
Logic looks good to me. Thanks @archmoj ! Do we have tests for the validators? Can we add a test for this change? |
Contributor
Author
Good call. Thank you! |
Contributor
Author
|
@LiamConnors The tests used to pass before your commit which simply added a line to the changelog. But now it fails. |
Contributor
Contributor
Author
|
I'll add tests in a separate PR later. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extrasare added to plotly.js integer validator in plotly/plotly.js@37dee48i.e. to handle cases like bold and normal in
font.weightwhich could also be a number between 1-1000.This commit would be required in updating to upcoming plotly.js v2.33.0.
@LiamConnors
cc: @emilykl @gvwilson