Skip to content

fix(transport): sanitize invalid NODE_OPTIONS preloads for workers#2391

Merged
mcollina merged 2 commits intomainfrom
fix/2389-transport-node-options-preload
Feb 9, 2026
Merged

fix(transport): sanitize invalid NODE_OPTIONS preloads for workers#2391
mcollina merged 2 commits intomainfrom
fix/2389-transport-node-options-preload

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented Feb 7, 2026

Fixes #2389.

Summary

  • sanitize inherited NODE_OPTIONS before spawning transport workers
  • remove only preload flags (--require/-r/--import) that reference missing absolute paths
  • support file:// preload values
  • do not mutate process.env in the parent process

Why

In Docker + VSCode debug setups, host-specific preload paths can be injected into NODE_OPTIONS and are not valid inside the container. Worker startup then fails before user code runs.

Tests

  • added regression fixture: test/fixtures/transport-invalid-node-options.js
  • added regression test in test/transport/preload.test.js
  • verified with npx borp --pattern test/transport/preload.test.js

@mcollina mcollina merged commit f1203e6 into main Feb 9, 2026
15 checks passed
@mcollina mcollina deleted the fix/2389-transport-node-options-preload branch February 9, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pino@10 transport worker inherits execArgv causing preload crash when debugging in Docker with VSCode

2 participants