Skip to content

Revert setlevel opt in 9.x#2323

Merged
mcollina merged 2 commits intov9.xfrom
revert-setlevel-opt-in-9.x
Oct 18, 2025
Merged

Revert setlevel opt in 9.x#2323
mcollina merged 2 commits intov9.xfrom
revert-setlevel-opt-in-9.x

Conversation

@mcollina
Copy link
Copy Markdown
Member

This reverts commit d6114a6.

Fixes #2287

…licitly set

When creating a child logger with an explicit level option (even if same as parent),
always call setLevel to ensure the child gets its own method references instead of
inheriting from the parent prototype. This prevents issues when parent methods are
wrapped by testing libraries like Sinon.

Fixes #2287

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina requested a review from jsumners October 14, 2025 14:34
@mcollina mcollina merged commit dde9348 into v9.x Oct 18, 2025
14 checks passed
@mcollina mcollina deleted the revert-setlevel-opt-in-9.x branch October 18, 2025 11:34
vaernion pushed a commit to Arbeidstilsynet/brevgen2 that referenced this pull request Dec 3, 2025
…&lt;9.13.1 to v9.14.0

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino@>=9.0.0 <9.13.1](https://getpino.io) ([source](https://github.com/pinojs/pino)) | [`9.13.1` -> `9.14.0`](https://renovatebot.com/diffs/npm/pino@&gt;&#x3D;9.0.0 &lt;9.13.1/9.13.1/9.14.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/9.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/9.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/9.13.1/9.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/9.13.1/9.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>pinojs/pino (pino@&gt;&#x3D;9.0.0 &lt;9.13.1)</summary>

### [`v9.14.0`](https://github.com/pinojs/pino/releases/tag/v9.14.0)

[Compare Source](pinojs/pino@v9.13.1...v9.14.0)

#### What's Changed

- feat(types): add LogFnFields by [@&#8203;samchungy](https://github.com/samchungy) in [#&#8203;2254](pinojs/pino#2254)
- \[v9.x] Update to pinojs redact by [@&#8203;mcollina](https://github.com/mcollina) in [#&#8203;2322](pinojs/pino#2322)
- Revert setlevel opt in 9.x by [@&#8203;mcollina](https://github.com/mcollina) in [#&#8203;2323](pinojs/pino#2323)

**Full Changelog**: <pinojs/pino@v9.13.1...v9.14.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!".

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Related work items: #30372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants