chore: add .npmignore to exclude unnecessary files#2312
Merged
Conversation
Excludes .github/, docsify/, .nyc_output/, coverage/, and PNG files. Reduces package size from 1.6MB to 141.3KB (91% reduction).
jsumners
approved these changes
Oct 4, 2025
Member
jsumners
left a comment
There was a problem hiding this comment.
I don't really like having to maintain the same list in two files. But I won't block it.
Comment on lines
+4
to
+5
| .nyc_output/ | ||
| coverage/ |
Member
There was a problem hiding this comment.
This is why we haven't done it before: these are already covered by .gitignore. With this PR merged, we'll have to maintain overlap. I wish .npmignore would augment instead of replace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.npmignorefile to exclude development and CI-related files from npm packages:.github/directorydocsify/directory.nyc_output/directory (test coverage)coverage/directory*.pngfilesImpact
Reduces package size from 1.6 MB to 141.3 kB (91% reduction).
Test Plan
npm pack --dry-run