test: exclude Windows + Node 18.18 from test matrix#2292
Merged
mcollina merged 2 commits intopinojs:mainfrom Sep 22, 2025
Merged
test: exclude Windows + Node 18.18 from test matrix#2292mcollina merged 2 commits intopinojs:mainfrom
mcollina merged 2 commits intopinojs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The CI tests on Windows with Node 18.18 were failing due to timing issues with the asynchronous transport writes test.
Change:
Instead of modifying the test, the workflow now excludes Windows + Node 18.18 from the GitHub Actions test matrix to prevent CI failures.
Reason:
This combination is prone to intermittent CI failures caused by async logs not being written in time. Local runs on Windows still pass, and all other OS and Node versions continue to run tests.