Handle repeated wildcards with params#421
Merged
blakeembrey merged 1 commit intomasterfrom Mar 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
===========================================
- Coverage 100.00% 99.75% -0.25%
===========================================
Files 1 1
Lines 369 403 +34
Branches 132 152 +20
===========================================
+ Hits 369 402 +33
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UlisesGascon
approved these changes
Mar 26, 2026
Member
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! Fantastic work @blakeembrey 👏 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better handling of subsequent wildcards when generating a regular expression. Alternatively we could limit matching to one wildcard per path.