Move parameter name errors up in docs#402
Merged
blakeembrey merged 1 commit intomasterfrom Sep 2, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 378 378
Branches 136 136
=========================================
Hits 378 378 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjohansebas
reviewed
Aug 27, 2025
Member
bjohansebas
left a comment
There was a problem hiding this comment.
In the Express documentation, I decided to use examples for this point. I’m not even sure if that’s been helping or not, but maybe here it could have an effect and help people migrate
Here you can use the diff format for those examples, showing what needs to be removed or added.
I'll leave the decision up to you.
wesleytodd
approved these changes
Sep 2, 2025
Member
Author
|
@bjohansebas I'll play around with it, right now the docs are pretty short so I'll try expanding them all and see how it looks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/*issue seems to be the most common, move it up and trying to make it more clear. Open to feedback on phrasing or rewriting the sentences entirely.