Correct parsing up to a potential partial boundary#3081
Merged
davidism merged 1 commit intopallets:stablefrom Jan 2, 2026
Merged
Correct parsing up to a potential partial boundary#3081davidism merged 1 commit intopallets:stablefrom
davidism merged 1 commit intopallets:stablefrom
Conversation
Closed
This adjusts b1916c0 by ensuring CR, \r, are not ignored if an earlier LR, \n, is present when considering if a partial boundary can exist. This would result in trailing CR, \r, being added to the data rather than part of a potential partial boundary.
jayaddison
reviewed
Jan 15, 2026
| def _last_partial_boundary_index(self, data: bytes | bytearray) -> int: | ||
| # Find the last index following which a partial boundary | ||
| # could be present in the data. This will be the earliest | ||
| # position of a LR or a CR, unless that position is more |
Contributor
|
Is it possible that this change created the following bug? #3088 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts b1916c0 by ensuring CR, \r, are not ignored if an earlier LR, \n, is present when considering if a partial boundary can exist. This would result in trailing CR, \r, being added to the data rather than part of a potential partial boundary.
This correctly fixes #3065 and fixes #3077.