fix: duplicate credential error placeholder case mismatch

pi1814 · ory-bot · commit 84ee59662ce4 · 2026-03-20T08:48:29.000Z
GitOrigin-RevId: 04b013ad8069ef993d337a0cb97ea7fea84c188e
diff --git a/text/message_test.go b/text/message_test.go
@@ -22,6 +22,23 @@ func TestMessage(t *testing.T) {
 	assert.EqualValues(t, expected, &actual, v)
 }
 
+func TestNewErrorValidationDuplicateCredentialsWithHints(t *testing.T) {
+	t.Run("title-cases real provider names", func(t *testing.T) {
+		msg := NewErrorValidationDuplicateCredentialsWithHints(nil, []string{"google", "github"}, "user@example.com")
+		assert.Contains(t, msg.Text, "Google, Github")
+	})
+
+	t.Run("preserves placeholder templates without title-casing", func(t *testing.T) {
+		msg := NewErrorValidationDuplicateCredentialsWithHints(
+			[]string{"{available_credential_types_list}"},
+			[]string{"{available_oidc_providers_list}"},
+			"{credential_identifier_hint}",
+		)
+		assert.Contains(t, msg.Text, "{available_oidc_providers_list}")
+		assert.NotContains(t, msg.Text, "{Available_oidc_providers_list}")
+	})
+}
+
 func TestMessages(t *testing.T) {
 	expected := Messages{{ID: InfoSelfServiceSettingsUpdateSuccess, Text: "foo", Type: Info}}
 
diff --git a/text/message_validation.go b/text/message_validation.go
@@ -312,7 +312,11 @@ func NewErrorValidationDuplicateCredentialsWithHints(availableCredentialTypes []
 	}
 	oidcProviders := make([]string, 0, len(availableOIDCProviders))
 	for _, provider := range availableOIDCProviders {
-		oidcProviders = append(oidcProviders, cases.Title(language.English).String(provider))
+		if strings.ContainsAny(provider, "{}") {
+			oidcProviders = append(oidcProviders, provider)
+		} else {
+			oidcProviders = append(oidcProviders, cases.Title(language.English).String(provider))
+		}
 	}
 
 	reason := fmt.Sprintf("You tried signing in with %s which is already in use by another account.", identifier)

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,11 @@ func NewErrorValidationDuplicateCredentialsWithHints(availableCredentialTypes []`
`312`	`312`	`}`
`313`	`313`	`oidcProviders := make([]string, 0, len(availableOIDCProviders))`
`314`	`314`	`for _, provider := range availableOIDCProviders {`
`315`		`- oidcProviders = append(oidcProviders, cases.Title(language.English).String(provider))`
	`315`	`+ if strings.ContainsAny(provider, "{}") {`
	`316`	`+ oidcProviders = append(oidcProviders, provider)`
	`317`	`+ } else {`
	`318`	`+ oidcProviders = append(oidcProviders, cases.Title(language.English).String(provider))`
	`319`	`+ }`
`316`	`320`	`}`
`317`	`321`
`318`	`322`	`reason := fmt.Sprintf("You tried signing in with %s which is already in use by another account.", identifier)`