StringUtils micro performance optimizations#7366
Merged
greg-at-moderne merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Applying local performance optimizations to several methods in
StringUtils.Origin/Context
These fixes have been suggested in #7259 and in PRs:
StringUtils.isBlankby 139% HeshamHM28/rewrite#43StringUtils.formatUriForPropertiesFileby 265% HeshamHM28/rewrite#54StringUtils.indexOfNextNonWhitespaceby 57% HeshamHM28/rewrite#53StringUtils.indentby 161% HeshamHM28/rewrite#49(... and slightly altered)
These are 4 out of 5 fixes categorized as "Tier 1" improvements.
Kudos to @HeshamHM28 🙇♂️
What's your motivation?
Benefit from slightly better performance in hot-path String operations.