Resolve Maven property references when matching dependency tags#7351
Merged
Resolve Maven property references when matching dependency tags#7351
Conversation
Fixes #4796 — `RemoveDependency` (and other recipes using `isDependencyTag` or `findDependency`) failed to match dependencies whose groupId or artifactId was defined via a Maven property (e.g. `${junit.groupId}`). The root cause was that `isDependencyTag` and `findDependency` in `MavenVisitor` compared raw XML tag values against resolved dependency coordinates without first resolving property placeholders. Now both methods use `ResolvedPom.getValue()` to expand properties before comparing.
steve-aom-elliott
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes RemoveDependency doesn't remove the dependency if one of its part is defined with properties #4796
isDependencyTag()andfindDependency()inMavenVisitorcompared raw XML tag values (e.g.${junit.groupId}) against resolved dependency coordinates (e.g.junit) without resolving property placeholders firstBoth methods now use
ResolvedPom.getValue()to expand Maven properties before comparing groupId and artifactIdTest plan
removeDependencyDefinedWithPropertiesthat uses${junit.groupId}property in a dependency's groupIdRemoveDependencyTesttests passrewrite-maventest suite passes