fix(span,sdk-logs): enforce event/link attribute limits, link count limit, and fix LogRecord droppedAttributesCount#6479
Merged
overbalance merged 5 commits intoopen-telemetry:mainfrom Mar 10, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6479 +/- ##
==========================================
+ Coverage 95.70% 95.73% +0.03%
==========================================
Files 364 364
Lines 11779 11826 +47
Branches 2751 2765 +14
==========================================
+ Hits 11273 11322 +49
+ Misses 506 504 -2
🚀 New features to boost your workflow:
|
796f189 to
8ea74d8
Compare
8ea74d8 to
7c220b6
Compare
dyladan
approved these changes
Mar 10, 2026
Merged
via the queue into
open-telemetry:main
with commit Mar 10, 2026
de02086
35 of 37 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Found during a spec compliance review: several
SpanLimitsoptions are accepted but not enforced at runtime, andLogRecordImplmiscounts dropped attributes. These are unlikely to surface at default limits (128) but become incorrect when limits are explicitly configured to lower values.attributePerEventCountLimitandattributePerLinkCountLimitare not enforced. Event/link attributes pass through unbounded.attributeValueLengthLimittruncates span-level attributes but not event or link attribute values.linkCountLimitis not enforced.addLink()/addLinks()/constructor links accumulate without bound.LogRecordImpl.droppedAttributesCountis incorrectly incremented when an existing attribute key is updated.Short description of the changes
Span.ts:
attributePerEventCountLimit,attributePerLinkCountLimit, andlinkCountLimitattributeValueLengthLimitaddLinks()throughaddLink()so limits apply uniformlyaddEvent()patternsattributeValueLengthLimitcoercion (||to??)LogRecordImpl.ts:
_attributesCountand_droppedAttributesCountexplicitly instead of deriving fromObject.keys().lengthType of change
How Has This Been Tested?
10 new unit tests covering event/link attribute count limits, event/link attribute value truncation, link count FIFO eviction, link count via constructor, link count = 0,
addLinks()limit enforcement, and LogRecorddroppedAttributesCountaccuracy on key updates.Checklist: