Add file size check for OtlpConfigUtils to avoid unsafe cast to int#8287
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8287 +/- ##
============================================
- Coverage 90.27% 90.26% -0.01%
Complexity 7684 7684
============================================
Files 850 850
Lines 23186 23189 +3
Branches 2352 2353 +1
============================================
+ Hits 20931 20932 +1
- Misses 1530 1531 +1
- Partials 725 726 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
commented
Apr 13, 2026
| try (RandomAccessFile raf = new RandomAccessFile(file, "r")) { | ||
| byte[] bytes = new byte[(int) raf.length()]; | ||
| long length = raf.length(); | ||
| if (length > Integer.MAX_VALUE) { |
Member
Author
There was a problem hiding this comment.
Not practical to unit test this. Requires a 2gb file.
jkwatson
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.