Stabilize ExemplarFilter#7768
Merged
jkwatson merged 3 commits intoopen-telemetry:mainfrom Oct 29, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7768 +/- ##
============================================
- Coverage 90.18% 90.17% -0.01%
- Complexity 7200 7203 +3
============================================
Files 815 816 +1
Lines 21738 21737 -1
Branches 2130 2130
============================================
- Hits 19604 19602 -2
- Misses 1466 1467 +1
Partials 668 668 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3debba9 to
906dd38
Compare
…y-java into stabilize-exemplar-filter
906dd38 to
d5e2988
Compare
breedx-splk
approved these changes
Oct 28, 2025
Contributor
breedx-splk
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for picking this back up -- I clearly didn't have the cycles to come back to this. 😮💨
| * | ||
| * @see SdkMeterProviderBuilder#setExemplarFilter(ExemplarFilter) | ||
| */ | ||
| // TODO(jack-berg): Have methods when custom filters are supported. |
Contributor
There was a problem hiding this comment.
Thanks, yeah without this TODO it sure looks like a weird interface. 👍🏻
jkwatson
approved these changes
Oct 29, 2025
Contributor
jkwatson
left a comment
There was a problem hiding this comment.
Some weird gyrations until we have clarity on the filter API, but good for now! 👍🏽
the-clam
pushed a commit
to the-clam/opentelemetry-java
that referenced
this pull request
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrower version of #7636.
Resolves #7503.
Notably: