Fix graalvm compatibility#7160
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7160 +/- ##
=========================================
Coverage 89.85% 89.85%
Complexity 6622 6622
=========================================
Files 740 740
Lines 20007 20007
Branches 1968 1968
=========================================
Hits 17978 17978
Misses 1439 1439
Partials 590 590 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc @jeanbisutti |
|
Hmm.. its not clear to me what the problem is with AttributeType that requires it to be handled with this special case. Can you provide a repro of the issue? Would good to add it to our graal test suite. |
|
@ericdallo Could you please provide the GraalVM version for which the problem appears? |
@jack-berg I reproed that using the log appender of timbre here on clojure-lsp, I can't spend more time on this though, so after this PR, I included on clojure-lsp here to fix my case meanwhile |
|
@jack-berg The native tests are executed with GraalVM 21: It may be worth to run them with version 23 as well (the last one). |
See #7167 |
|
Is this still needed/wanted? It's been open a while, and I don't have a problem with it, but let's either get it merged, or close it. |
|
It's still a improvement for default, I suggest merge it so users don't need to spend debugging I like I did |
|
Thank you for your contribution @ericdallo! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This fix a graalvm compatibility with the logger api (only one I tested in my lib), this exports the graalvm config automatically for clients.