Extract sender parameters to config carrier class#7151
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Mar 6, 2025
Merged
Extract sender parameters to config carrier class#7151jack-berg merged 1 commit intoopen-telemetry:mainfrom
jack-berg merged 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7151 +/- ##
============================================
+ Coverage 89.87% 89.89% +0.01%
- Complexity 6623 6627 +4
============================================
Files 740 742 +2
Lines 20008 20047 +39
Branches 1968 1968
============================================
+ Hits 17982 18021 +39
Misses 1437 1437
Partials 589 589 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6718.
Reduces churn of the GrpcSenderProvider, HttpSenderProvider interfaces by extracting all config parameters into a carrier class, which can be extended with default implementations when new options are added.
#7152 would need to churn the API contract in order to accommodate the new
ExecutorServiceparameter. Instead, because its built off of this PR, it can be done as a non-breaking change.This will be important if we want to promote sender API to public as discussed in #6781.