sdk/log: improve Processor documentation#7695
Merged
Merged
Conversation
- Clarify EnabledParameters contents and Enabled decision semantics - Remove the requirement of Enabled that param cannot be held by the implementation as it is immutable - Refine OnEmit docs around context cancellation and retry handling - Update Shutdown docs to mention Processor/Exporter and OnEmit instead of Export
Member
Author
|
FYI @bboreham |
Removed redundant comment about Record parameters.
- Clarify that EnabledParameters may omit fields present on the final Record - Note that unset param fields do not imply unset fields on the emitted Record
dmathieu
approved these changes
Dec 11, 2025
dashpole
approved these changes
Dec 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7695 +/- ##
=====================================
Coverage 86.2% 86.2%
=====================================
Files 298 298
Lines 21829 21829
=====================================
+ Hits 18817 18819 +2
+ Misses 2635 2634 -1
+ Partials 377 376 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7685