Merged
Conversation
Signed-off-by: yash solanki <alphacr792@gmail.com>
Signed-off-by: yash solanki <alphacr792@gmail.com>
23fef69 to
b651bb7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7608 +/- ##
==========================================
+ Coverage 55.27% 55.29% +0.02%
==========================================
Files 515 515
Lines 32446 32462 +16
Branches 2898 2898
==========================================
+ Hits 17933 17949 +16
Misses 13724 13724
Partials 789 789 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
hey @justinchuby any thoughts? |
titaiwangms
reviewed
Feb 2, 2026
Contributor
titaiwangms
left a comment
There was a problem hiding this comment.
Does it work on the issue repro code?
Contributor
Author
Yes, I ran the issue’s repro after the fix and it now preserves the mapped output value_info as expected. The new test in compose_test.py covers the same case (mapped output becomes internal and value_info is retained). |
titaiwangms
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7321