Fix CMAKE_ARGS parsing for windows compatibility#7532
Merged
justinchuby merged 1 commit intoonnx:mainfrom Dec 28, 2025
Merged
Conversation
Previously the `\` would be stripped because it assumed posix. Essentially breaking any directive to specify an INSTALL_PREFIX on windows. Signed-off-by: Mark Harfouche <mark.harfouche@gmail.com>
justinchuby
approved these changes
Dec 28, 2025
Member
|
Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7532 +/- ##
=======================================
Coverage 55.20% 55.20%
=======================================
Files 515 515
Lines 32324 32324
Branches 2897 2897
=======================================
Hits 17844 17844
Misses 13688 13688
Partials 792 792 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
\would be stripped because it assumed posix.Essentially breaking any directive to specify an INSTALL_PREFIX on windows.