Skip to content

Export functions used in PyTorch#7524

Merged
justinchuby merged 1 commit intoonnx:mainfrom
cyyever:more_export
Dec 16, 2025
Merged

Export functions used in PyTorch#7524
justinchuby merged 1 commit intoonnx:mainfrom
cyyever:more_export

Conversation

@cyyever
Copy link
Copy Markdown
Contributor

@cyyever cyyever commented Dec 15, 2025

Motivation and Context

This PR exports more symbols which are used by PyTorch and other libraries. Specifically, header symbols are no longer hidden to export Protobuf symbols by removing

set_target_properties(onnx PROPERTIES VISIBILITY_INLINES_HIDDEN ON)

This PR fixes #7377

@cyyever cyyever requested a review from a team as a code owner December 15, 2025 02:46
@github-project-automation github-project-automation Bot moved this to In progress in PR Tracker Dec 15, 2025
@cyyever cyyever added the topic: build Issues related to ONNX builds and packages label Dec 15, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.20%. Comparing base (a85600e) to head (fdc78b4).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7524   +/-   ##
=======================================
  Coverage   55.20%   55.20%           
=======================================
  Files         515      515           
  Lines       32324    32324           
  Branches     2897     2897           
=======================================
  Hits        17844    17844           
  Misses      13688    13688           
  Partials      792      792           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
@cyyever cyyever added the run release CIs Use this label to trigger release tests in CI label Dec 15, 2025
@github-project-automation github-project-automation Bot moved this from In progress to Reviewer approved in PR Tracker Dec 15, 2025
@andife andife self-requested a review December 15, 2025 16:13
@justinchuby
Copy link
Copy Markdown
Member

Could you fix lint?

@justinchuby justinchuby added this to the 1.20.1 milestone Dec 15, 2025
@cyyever
Copy link
Copy Markdown
Contributor Author

cyyever commented Dec 16, 2025

Fixed

Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@justinchuby justinchuby merged commit 992dd36 into onnx:main Dec 16, 2025
42 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in PR Tracker Dec 16, 2025
@cyyever cyyever deleted the more_export branch December 16, 2025 03:05
justinchuby pushed a commit that referenced this pull request Jan 8, 2026
### Motivation and Context

This PR exports more symbols which are used by PyTorch and other
libraries. Specifically, header symbols are no longer hidden to export
Protobuf symbols by removing
```
set_target_properties(onnx PROPERTIES VISIBILITY_INLINES_HIDDEN ON)
```
 
This PR fixes #7377

Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
justinchuby added a commit that referenced this pull request Jan 8, 2026
- #7505 
- #7515 
- #7524 
- #7525

---------

Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Co-authored-by: Yuanyuan Chen <cyyever@outlook.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run release CIs Use this label to trigger release tests in CI topic: build Issues related to ONNX builds and packages

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Fails to build macOS shared lib in 1.18.0, 1.19.0, main (075e319)

3 participants