Remove enforcement to node determinism attribute#7473
Merged
titaiwangms merged 1 commit intoonnx:mainfrom Nov 20, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7473 +/- ##
=======================================
Coverage 55.12% 55.12%
=======================================
Files 512 512
Lines 32107 32107
Branches 2885 2885
=======================================
Hits 17700 17700
Misses 13618 13618
Partials 789 789 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
d5271bc to
b2c99a8
Compare
gramalingam
approved these changes
Nov 20, 2025
titaiwangms
added a commit
to titaiwangms/onnx
that referenced
this pull request
Nov 21, 2025
### Motivation and Context From onnx#7176, a node determinism attribute to operator schemas was introduced. However, there is an enforcement making the changes bc breaking to exising op schemas. This PR removed the enforcement to relax the constraints. An alternative way could be making NonDeterministic as a default to operators to ease the impacts. Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
titaiwangms
added a commit
that referenced
this pull request
Nov 25, 2025
#7473 Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
From #7176, a node determinism attribute to operator schemas was introduced. However, there is an enforcement making the changes bc breaking to exising op schemas. This PR removed the enforcement to relax the constraints.
An alternative way could be making NonDeterministic as a default to operators to ease the impacts.