perf(vite): start warmups after nitro build#27963
Merged
Conversation
|
|
antfu
approved these changes
Jul 2, 2024
Member
|
Looks very nice! Re: Vite warmup: I have not been using Windows for a long while to tell if it's a Vite bug. I guess it would need a reproduction to make sure it's about vite (or maybe our path normalization?) |
Merged
danielroe
added a commit
that referenced
this pull request
Jul 2, 2024
Merged
Kamsou
pushed a commit
to Kamsou/nuxt
that referenced
this pull request
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#26211
#27106
📚 Description
Investigating reports of slow startup time for Nuxt, I think there are a couple of ways we can improve things:
We definitely warm up fewer files this way (for example, in the test fixture I'm running, we don't warm up plugin files) and this may be a problem.
I'm also - related to #26211 - trying to track down an issue on Windows machines where vite warmup seems to be non-effective in the server build - even passing entry file to
server.warmupdoesn't yield transform results for key files. (Maybe a Vite bug - cc: @antfu?)