Skip to content

feat(nuxt): ensure prefetchComponents be treeshake on server#27905

Merged
danielroe merged 1 commit intonuxt:mainfrom
Mini-ghost:feat/treeshake-prefetchComponents
Jun 29, 2024
Merged

feat(nuxt): ensure prefetchComponents be treeshake on server#27905
danielroe merged 1 commit intonuxt:mainfrom
Mini-ghost:feat/treeshake-prefetchComponents

Conversation

@Mini-ghost
Copy link
Copy Markdown
Member

@Mini-ghost Mini-ghost commented Jun 28, 2024

🔗 Linked issue

N/A

📚 Description

Before

export const prefetchComponents = (components: string | string[]) => {
  return preloadComponents(components)
}
Before

prefetchComponents and preloadComponents are both not tree shaken on the server side.

After

export const prefetchComponents = (components: string | string[]) => {
  if (import.meta.server) { return }
  return preloadComponents(components)
}
After

prefetchComponents and preloadComponents are both tree shaken on the server side.

@Mini-ghost Mini-ghost requested a review from danielroe as a code owner June 28, 2024 17:42
@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz Bot commented Jun 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit 07ef633 into nuxt:main Jun 29, 2024
@github-actions github-actions Bot mentioned this pull request Jun 29, 2024
Merged
danielroe pushed a commit that referenced this pull request Jun 29, 2024
@Mini-ghost @danielroe
perf(nuxt): ensure prefetchComponents is treeshaken on server (#27905)
3c2eebd
@github-actions github-actions Bot mentioned this pull request Jun 29, 2024
Merged
2 tasks
danielroe pushed a commit that referenced this pull request Jun 29, 2024
@Mini-ghost @danielroe
perf(nuxt): ensure prefetchComponents is treeshaken on server (#27905)
6b8b3d0
@mjbullman mjbullman mentioned this pull request Jul 24, 2024
Closed
@kingchappers kingchappers mentioned this pull request Jul 24, 2024
Closed
@BalaKadiyala BalaKadiyala mentioned this pull request Jul 27, 2024
Open
Kamsou pushed a commit to Kamsou/nuxt that referenced this pull request Feb 5, 2025
@Mini-ghost @Kamsou
perf(nuxt): ensure prefetchComponents is treeshaken on server (nuxt…
e1a9c03 
…#27905)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

3.x enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mini-ghost @danielroe