fix: not correctly matching client component when teleporting#27633
Merged
fix: not correctly matching client component when teleporting#27633
Conversation
|
|
huang-julien
approved these changes
Jun 15, 2024
Member
huang-julien
left a comment
There was a problem hiding this comment.
Nice work ! Can you revert the formatting changes ?
Contributor
Author
You mean formatting the whole file as it was in the first commit or remove the changed formatting in the other rows? First time I just saved and linted the whole file, while in the second commit I ran |
Contributor
Author
|
Think it's ok now. Can you trigger a nuxt edge channel release afterwards so I can make use of this change? I have some ideas for server components that makes sense after this |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #27210
📚 Description
Adding missing island uid when matching teleports in ssr renderer for island selective client components
@huang-julien