Skip to content

ci: use correct SHA calculation for release-pr action#27604

Merged
danielroe merged 2 commits intonuxt:mainfrom
avivkeller:patch-1
Jun 19, 2024
Merged

ci: use correct SHA calculation for release-pr action#27604
danielroe merged 2 commits intonuxt:mainfrom
avivkeller:patch-1

Conversation

@avivkeller
Copy link
Copy Markdown
Contributor

${{ github.event.issue.pull_request.head.sha }} does not exist (My bad!).

This PR updates the logic to correctly calculate the SHA.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Comment thread .github/workflows/release-pr.yml
@danielroe danielroe changed the title fix(security): use correct SHA calculation ci: use correct SHA calculation for release-pr action Jun 19, 2024
Comment thread .github/workflows/release-pr.yml Outdated
Comment thread .github/workflows/release-pr.yml
@danielroe danielroe merged commit cc2e56c into nuxt:main Jun 19, 2024
@github-actions github-actions Bot mentioned this pull request Jun 19, 2024
@danielroe
Copy link
Copy Markdown
Member

This doesn't yet seem to work as expected.

@avivkeller
Copy link
Copy Markdown
Contributor Author

avivkeller commented Jun 20, 2024 via email

@avivkeller
Copy link
Copy Markdown
Contributor Author

Oh I see it’s a syntax error, sorry, I’m not a bash syntax expert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants